[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In D84380#2310504 <https://reviews.llvm.org/D84380#2310504>, @stella.stamenova wrote:

> In D84380#2309885 <https://reviews.llvm.org/D84380#2309885>, @stella.stamenova wrote:
>
>> In D84380#2309853 <https://reviews.llvm.org/D84380#2309853>, @aganea wrote:  Maybe if L28 wasn't there, things would work correctly if you already had the required tools in %PATH%? Would you possibly try that please?
>>
>>> 
>>
>> I will try it. I'll let you know if it makes a difference.
>
> Yes, that works. We don't end up prepending the lit path and the tests work as before.

For some context, L28 was added because the previous code made the underlying assumption that this variable was defined.  Specifically, this:

  path = self.lit_config.getToolsPath(lit_tools_dir, config.environment['PATH'], required_tools)

will raise an exception if `lit_tools_dir` is None.  It sounds like you're saying `lit_tools_dir = []` in your case.  If so, instead of removing this line, can it be changed to `if lit_tools_dir != None:`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380