[PATCH] D88307: [DON'T MERGE] Jump-threading for finite state automata

Ehsan Amiri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 3 19:14:40 PDT 2020


amehsan added a comment.

@alexey.zhikhar and I had a look at your patch. Some findings that might be interesting:

1- The IR from your patch is shorter than ours. We haven't checked carefully where the difference is, but there is a gap of about 10% (of the size of `core_state_transition`)
2- Our code from our current implementation is about 2%-3% faster on our platform. 
3- While the main idea is exactly the same our implementation looks at all the control flow paths in the loop first and perform the analysis. Then we have a code gen process. Your approach is closer to the existing jump threading in that you make one change at a time. 
4- As I said, we are making some significant changes in our implementation to improve the code quality, etc.  So our new code that we will be able to share is not ready yet.

Thanks for sharing your code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88307/new/

https://reviews.llvm.org/D88307



More information about the llvm-commits mailing list