[PATCH] D88400: [llvm-objcopy][MachO] Add support for universal binaries

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 3 18:37:19 PDT 2020


alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/universal-object.test:1
+# This test verifies that llvm-objcopy copies a univeral Mach-O object file properly.
+
----------------
smeenai wrote:
> All of these tests are just for copies. We should also have some tests for performing actual operations (e.g. stripping) to show that we correctly apply the operation to each slice.
sure, I'll add a test for stripping as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88400/new/

https://reviews.llvm.org/D88400



More information about the llvm-commits mailing list