[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 21:50:09 PDT 2020


tlively marked 2 inline comments as done and an inline comment as not done.
tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1600
+        I64s[I / HalfLanes] |= Val << Shift;
+        ConstLaneMasks[I / HalfLanes] |= ((1ULL << LaneBits) - 1) << Shift;
+      }
----------------
hubert.reinterpretcast wrote:
> Can `LaneBits` be 64?
Yes, if the vector is already an v2i64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88773/new/

https://reviews.llvm.org/D88773



More information about the llvm-commits mailing list