[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 21:03:37 PDT 2020


tlively created this revision.
tlively added reviewers: aheejin, efriedma, dweber, hubert.reinterpretcast.
Herald added subscribers: llvm-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: LLVM.
tlively requested review of this revision.

This reverts commit 432e4e56d3d2 <https://reviews.llvm.org/rG432e4e56d3d25c209b3336655aa374095e695956>, which reverted 542523a61a21 <https://reviews.llvm.org/rG542523a61a21c13e7f244bcf821b0fdeb8c6bb24>. Two issues from
the original commit have been fixed. First, MSVC does not like when std::array
is initialized with only single braces, so this commit switches to using the
more portable double braces. Second, there was a subtle endianness bug that
prevented the original commit from working correctly on big-endian machines,
which has been fixed by switching to using endianness-agnostic bit twiddling
instead of type punning.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88773

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/test/CodeGen/WebAssembly/simd-build-vector.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88773.295957.patch
Type: text/x-patch
Size: 8595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201003/f28cbeed/attachment.bin>


More information about the llvm-commits mailing list