[PATCH] D88750: [GlobalISel] Add G_VECREDUCE_* opcodes for vector reductions

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 16:14:47 PDT 2020


aemerson added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:553
+
+G_VECREDUCE_STRICT_FADD, G_VECREDUCE_STRICT_FMUL
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
----------------
arsenm wrote:
> This name is extremely confusing since these aren't strict FP operations
What other name do you suggest? If we change it then we should also change the SDAG node too.

VECREDUCE_STRICT_ORDER_FADD? VECREDUCE_ORDERED_FADD? VECREDUCE_SEQ_FADD?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88750/new/

https://reviews.llvm.org/D88750



More information about the llvm-commits mailing list