[PATCH] D88661: llvm-diva - Debug Information Visual Analizer

Fri Oct 2 12:17:57 PDT 2020

MaskRay added a comment.

In D88661#2308140 <https://reviews.llvm.org/D88661#2308140>, @CarlosAlbertoEnciso wrote:

> In D88661#2307121 <https://reviews.llvm.org/D88661#2307121>, @MaskRay wrote:
>
>> (If you use `arc diff` to upload a patch (https://llvm.org/docs/GettingStarted.html#sending-patches), reviewers can use `arc patch D88661` to apply the patch locally.
>> This patch does not have a/ b/ prefixes (git format-patch or git diff) and does not apply cleanly)
>
> Uploaded a correct patch that includes the a/ b/ prefixes.

For CMake changes, it'd be good to test a -DBUILD_SHARED_LIBS=on configuration. Many unspecified dependency can be caught. It also pushes the author to think whether certain dependencies are needed.

  FAILED: lib/libLLVMDebugInfoLogicalView.so.12git
  ...
  ld.lld: error: undefined symbol: llvm::raw_ostream::write(char const*, unsigned long)
  ld.lld: error: undefined symbol: llvm::Twine::str[abi:cxx11]() const

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88661/new/

https://reviews.llvm.org/D88661