[PATCH] D88674: Add --delete_all_rpaths to llvm-install-name-tool

Fri Oct 2 10:59:42 PDT 2020

rupprecht added a comment.

Can you also update `install-name-tool-delete-rpath.test` with a test case for this?

This seems fine to me. In general for our binutils-like tools, we allow extra flags for useful behavior as long as they don't have short prefixes (that may be someday used by GNU binutils, and we may want to match), which you have avoided here.

================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:145
       StringRef RPath = getPayloadString(LC);
+
       if (RPathsToRemove.count(RPath)) {
----------------
tiny tiny nit: this extra blank line seems unnecessary.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88674/new/

https://reviews.llvm.org/D88674