[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 10:53:02 PDT 2020


aeubanks added a comment.

In D88609#2304497 <https://reviews.llvm.org/D88609#2304497>, @davidxl wrote:

> I like the direction of the patch. There is one concern -- it makes the IR not backward compatible which may affect some users. +vsk.

I'm not too familiar with this, but it looks like weights are read via `C->getValue().getZExtValue()`, which should work with `i32` and `i64`.
Maybe some version of LLVM without this commit that reads IR generated by a later version of LLVM with this commit will incorrectly read weights larger than `i32`, but not sure if that's a concern or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88609/new/

https://reviews.llvm.org/D88609



More information about the llvm-commits mailing list