[PATCH] D88523: scudo: Make it thread-safe to set some runtime configuration flags.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 10:31:32 PDT 2020


pcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/options.h:66
+        break;
+    }
+  }
----------------
eugenis wrote:
> This could be more readable in the form of 
> ```
> do { ... } while (!atomic_compare_exchange_strong
> ```
> 
> Also, there is no need to reload Opts on each iteration - compare_exchange does it for you.
D88747


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88523/new/

https://reviews.llvm.org/D88523



More information about the llvm-commits mailing list