[PATCH] D88087: [SCEV] Limited support for unsigned preds in isImpliedViaOperations

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D88087#2308077 <https://reviews.llvm.org/D88087#2308077>, @xbolva00 wrote:

> https://llvm-compile-time-tracker.com/compare.php?from=f29645e7afdbb8d1fc2dd603c0b128bac055625c&to=b8ac19cf1cca5faec8b4404bb0f666cb63c9e1de&stat=instructions
>
> Compile time regressed a bit but I see no binary changes so.. how useful is this in practise? Any benchmark data to justify small regression?

I'll assert this is justified.  Only being able to handle signed predicates when we canonicalize to unsigned is a bit of a problem.  :)

Can you be more specific about how much compile time regressed and on what?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88087/new/

https://reviews.llvm.org/D88087