[PATCH] D88708: [AMDGPU] Allow SOP asm mnemonic to differ

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 15:35:24 PDT 2020


Joe_Nash created this revision.
Joe_Nash added reviewers: arsenm, rampitec, nhaehnle.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, yaxunl, jvesely, kzhuravl.
Herald added a project: LLVM.
Joe_Nash requested review of this revision.
Herald added a subscriber: wdng.

Allows the creation of real SOP1 instructions with
assembler mnemonics that differ from their
pseudo-instruction mnemonics. The default behavior
keeps the mnemonics matching.

Corrects a subtarget label typo in a comment.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88708

Files:
  llvm/lib/Target/AMDGPU/SOPInstructions.td


Index: llvm/lib/Target/AMDGPU/SOPInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/SOPInstructions.td
+++ llvm/lib/Target/AMDGPU/SOPInstructions.td
@@ -54,9 +54,9 @@
   bits<1> has_sdst = 1;
 }
 
-class SOP1_Real<bits<8> op, SOP1_Pseudo ps> :
+class SOP1_Real<bits<8> op, SOP1_Pseudo ps, string real_name = ps.Mnemonic> :
   InstSI <ps.OutOperandList, ps.InOperandList,
-          ps.Mnemonic # " " # ps.AsmOperands, []>,
+          real_name # " " # ps.AsmOperands, []>,
   Enc32 {
 
   let isPseudo = 0;
@@ -1621,7 +1621,7 @@
 defm S_SETREG_IMM32_B32 : SOPK_Real64_gfx6_gfx7_gfx10<0x015>;
 
 //===----------------------------------------------------------------------===//
-// GFX8, GFX9 (VI).
+// GFX8 (VI), GFX9.
 //===----------------------------------------------------------------------===//
 
 class Select_vi<string opName> :


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88708.295683.patch
Type: text/x-patch
Size: 896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201001/e8f2885b/attachment.bin>


More information about the llvm-commits mailing list