[PATCH] D88697: [WebAssembly] Rename Emscripten EH functions

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:118
-      // imports. so fix the names and the tests, or rethink how import
-      // delcarations work in asm files.
       getTargetStreamer()->emitFunctionType(Sym);
----------------
This comment doesn't sound relevant now. This was added in D52580 by @dschuff, and then the line below this comment was this:
```
getTargetStreamer()->emitIndirectFunctionType(Sym);
```

I don't know the full history, but the comment seemed to be somehow related to indirect function types, but it seems we are using this for all functions types, so we don't need this FIXME anymore..?


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:121
 
-      if (TM.getTargetTriple().isOSBinFormatWasm() &&
-          F.hasFnAttribute("wasm-import-module")) {
----------------
I guess now `isOSBinFormatWasm()` is always true? So removed it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88697/new/

https://reviews.llvm.org/D88697