[PATCH] D88591: [WebAssembly] Emulate v128.const efficiently

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 13:15:46 PDT 2020


tlively added a comment.

In D88591#2306093 <https://reviews.llvm.org/D88591#2306093>, @aheejin wrote:

> The number of instructions is the same, but because we are now using `i64.const` rather than `i32.const`, can this increase the code size?

Yes, you're right code size can increase. However, once we enable v128.const by default, the code size will increase even more. We've generally been trying to optimize SIMD code to minimize the number of instructions (and more generally maximize performance) rather than minimizing code size, so I don't think this is a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88591/new/

https://reviews.llvm.org/D88591



More information about the llvm-commits mailing list