[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 10:55:58 PDT 2020


sfertile added a comment.

More test coverage for this patch:

1. We should test spill/restore code when we have gpr/fpr/vr callee-saves all in the same function.
2. Extend at least one of the frame-pointer and base pointer tests to have a vector callee-saved clobbered.

See `inline-asm-vsx-clobbers.ll`. We should have a test which uses vsx registers to clobber fprs and vector registers and makes sure we allocate the right stack size, emit the right spills/restores. I think it should be a separate patch though as its testing the inline-asm implementation more, where the other test use inline-asm to test the frame-lowering.  I can prepare this patch if you like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88676/new/

https://reviews.llvm.org/D88676



More information about the llvm-commits mailing list