[PATCH] D88627: Revert "[AIX] Try to not use LLVM tools while building runtimes"

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 08:27:40 PDT 2020


daltenty added a comment.

This actually isn't exclusively a revert of D85329 <https://reviews.llvm.org/D85329> "[AIX] Try to not use LLVM tools while building runtimes" as the title seems to suggest. Before that patch there were already explicit `TOOLCHAIN_TOOLS` specified in the call to `llvm_ExternalProject_Add` in the runtimes build, which already suppressed the target-specific tool selection as mention in the description here.

That said, I'm not opposed to the resulting change, which moves all that logic to one place rather than having an extra layer on top just for the runtimes build. We should clarify the title and description though, because removing the `TOOLCHAIN_TOOLS` here entirely will actually be a new change to how runtimes are built.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88627/new/

https://reviews.llvm.org/D88627



More information about the llvm-commits mailing list