[PATCH] D88541: [AArch64] Don't merge sp decrement into later stores when using WinCFI

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 15:17:53 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1869
+      return E;
+  }
+
----------------
If we're using the same code to do this check in multiple places, should we factor it out?


================
Comment at: llvm/test/CodeGen/AArch64/arm64-windows-calls.ll:32
+; CHECK-NEXT:    .seh_endprologue
+; CHECK-NEXT:    stp     xzr, xzr, [sp]
 ; CHECK-NEXT:    mov     x0, xzr
----------------
Technically speaking, we could do this merge, but probably not worth implementing that transform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88541/new/

https://reviews.llvm.org/D88541



More information about the llvm-commits mailing list