[PATCH] D76883: [AMDGPU] Implement CFI for CSR spills

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 14:38:57 PDT 2020


greened added a comment.

I don't really have the expertise to approve this.  The patch looks fine from a readability standpoint.



================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1403
 // explicit register for it. However, DisableFramePointerElim will force us to
 // use a register for it.
+bool SIFrameLowering::spillCalleeSavedRegisters(
----------------
Does this comment need to be moved?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76883/new/

https://reviews.llvm.org/D76883



More information about the llvm-commits mailing list