[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 13:02:45 PDT 2020


aeubanks created this revision.
Herald added subscribers: llvm-commits, wenlei, dexonsmith, steven_wu, zzheng, hiraditya, eraman.
Herald added a project: LLVM.
aeubanks requested review of this revision.

CallInst::updateProfWeight() creates branch_weights with i64 instead of i32.
To be more consistent everywhere and remove lots of casts from uint64_t
to uint32_t, use i64 for branch_weights.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88609

Files:
  llvm/include/llvm/IR/Instructions.h
  llvm/include/llvm/IR/MDBuilder.h
  llvm/include/llvm/Transforms/Scalar/LowerExpectIntrinsic.h
  llvm/include/llvm/Transforms/Utils/MisExpect.h
  llvm/lib/IR/Instructions.cpp
  llvm/lib/IR/MDBuilder.cpp
  llvm/lib/Transforms/IPO/SampleProfile.cpp
  llvm/lib/Transforms/Instrumentation/ControlHeightReduction.cpp
  llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  llvm/lib/Transforms/Scalar/JumpThreading.cpp
  llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/lib/Transforms/Utils/MisExpect.cpp
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp
  llvm/test/Instrumentation/AddressSanitizer/basic.ll
  llvm/test/Transforms/CodeExtractor/MultipleExitBranchProb.ll
  llvm/test/Transforms/CorrelatedValuePropagation/profmd.ll
  llvm/test/Transforms/JumpThreading/threading_prof1.ll
  llvm/test/Transforms/JumpThreading/threading_prof2.ll
  llvm/test/Transforms/JumpThreading/update-edge-weight.ll
  llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt.ll
  llvm/test/Transforms/LoopUnroll/peel-loop-pgo.ll
  llvm/test/Transforms/LoopUnroll/runtime-loop-branchweight.ll
  llvm/test/Transforms/LoopVectorize/check-prof-info.ll
  llvm/test/Transforms/LoopVectorize/tripcount.ll
  llvm/test/Transforms/LowerExpectIntrinsic/basic.ll
  llvm/test/Transforms/LowerExpectIntrinsic/expect-with-probability.ll
  llvm/test/Transforms/LowerExpectIntrinsic/expect_nonboolean.ll
  llvm/test/Transforms/LowerExpectIntrinsic/phi_merge.ll
  llvm/test/Transforms/LowerExpectIntrinsic/phi_or.ll
  llvm/test/Transforms/LowerExpectIntrinsic/phi_tern.ll
  llvm/test/Transforms/PGOProfile/branch1.ll
  llvm/test/Transforms/PGOProfile/branch2.ll
  llvm/test/Transforms/PGOProfile/chr.ll
  llvm/test/Transforms/PGOProfile/criticaledge.ll
  llvm/test/Transforms/PGOProfile/cspgo_profile_summary.ll
  llvm/test/Transforms/PGOProfile/fix_entry_count.ll
  llvm/test/Transforms/PGOProfile/icp_covariant_call_return.ll
  llvm/test/Transforms/PGOProfile/icp_covariant_invoke_return.ll
  llvm/test/Transforms/PGOProfile/icp_invoke.ll
  llvm/test/Transforms/PGOProfile/icp_vararg.ll
  llvm/test/Transforms/PGOProfile/indirect_call_promotion.ll
  llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail.ll
  llvm/test/Transforms/PGOProfile/indirect_call_promotion_vla.ll
  llvm/test/Transforms/PGOProfile/indirectbr.ll
  llvm/test/Transforms/PGOProfile/instr_entry_bb.ll
  llvm/test/Transforms/PGOProfile/landingpad.ll
  llvm/test/Transforms/PGOProfile/loop1.ll
  llvm/test/Transforms/PGOProfile/loop2.ll
  llvm/test/Transforms/PGOProfile/memop_size_opt.ll
  llvm/test/Transforms/PGOProfile/multiple_hash_profile.ll
  llvm/test/Transforms/PGOProfile/noreturncall.ll
  llvm/test/Transforms/PGOProfile/remap.ll
  llvm/test/Transforms/PGOProfile/select1.ll
  llvm/test/Transforms/PGOProfile/select2.ll
  llvm/test/Transforms/PGOProfile/switch.ll
  llvm/test/Transforms/PGOProfile/thinlto_cspgo_use.ll
  llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
  llvm/test/Transforms/SCCP/switch.ll
  llvm/test/Transforms/SampleProfile/entry_counts_cold.ll
  llvm/test/Transforms/SampleProfile/indirect-call.ll
  llvm/test/Transforms/SampleProfile/inline-mergeprof-dup.ll
  llvm/test/Transforms/SampleProfile/inline-mergeprof.ll
  llvm/test/Transforms/SampleProfile/profile-format.ll
  llvm/test/Transforms/SimpleLoopUnswitch/basictest-profmd.ll
  llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch-profmd.ll
  llvm/test/Transforms/SimplifyCFG/invoke_unwind.ll
  llvm/test/Transforms/SimplifyCFG/preserve-branchweights-switch-create.ll
  llvm/test/Transforms/SimplifyCFG/preserve-branchweights.ll
  llvm/test/Transforms/SimplifyCFG/switch-profmd.ll
  llvm/test/Transforms/Util/libcalls-shrinkwrap-double.ll
  llvm/test/Transforms/Util/libcalls-shrinkwrap-float.ll
  llvm/test/Transforms/Util/libcalls-shrinkwrap-long-double.ll
  llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88609.295383.patch
Type: text/x-patch
Size: 71784 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200930/8dde3884/attachment.bin>


More information about the llvm-commits mailing list