[PATCH] D88604: Readability improvement in binary->decimal conversion

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 12:39:14 PDT 2020


klausler created this revision.
klausler added a reviewer: schweitz.
klausler added a project: Flang.
Herald added a reviewer: jdoerfert.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
klausler requested review of this revision.

Tweak binary->decimal conversions to avoid an integer multiplication
in a hot loop to improve readability and get a minor (~5%) speed-up.
Use native integer division by constants for more readability, too,
since current build compilers seem to optimize it correctly now.
Delete the now needless temporary work-around facility in
Common/unsigned-const-division.h.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88604

Files:
  flang/include/flang/Common/unsigned-const-division.h
  flang/lib/Decimal/big-radix-floating-point.h
  flang/lib/Decimal/binary-to-decimal.cpp
  flang/runtime/edit-output.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88604.295376.patch
Type: text/x-patch
Size: 7953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200930/01c9b402/attachment.bin>


More information about the llvm-commits mailing list