[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

One nit, otherwise lgtm

Thanks for doing this!



================
Comment at: llvm/include/llvm/Target/TargetMachine.h:300
+  virtual void registerPassBuilderCallbacks(PassBuilder &,
+                                            bool DebugPassManager = false) {}
+
----------------
I'd prefer no default value so callers don't forget to pass it since there should always be a user option to enable pass manager logging, which is already somewhat enforced by no default value for debug logging in the constructors for the various pass managers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88138/new/

https://reviews.llvm.org/D88138