[PATCH] D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/ppc64-tls-pcrel-gd.s:108
+.section .text_val, "ax", %progbits
+GDVal:
+  paddi 3, 0, x at got@tlsgd at pcrel, 1
----------------
It seems that GDAddr vs GDVal does not add test coverage as well.

I think the test can be simply:

```
  paddi 3, 0, x at got@tlsgd at pcrel, 1
  bl __tls_get_addr at notoc(x at tlsgd)
  paddi 4, 0, y at got@tlsgd at pcrel, 1
  bl __tls_get_addr at notoc(y at tlsgd)
  blr
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87318/new/

https://reviews.llvm.org/D87318