[PATCH] D88241: OpaquePtr: Add type to sret attribute

Sanne Wouda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 02:09:23 PDT 2020


sanwou01 added a comment.

Thanks @tpopp, that'll unblock all of us.

Apologies for not following up on this thread earlier; I figured mentioning this review in the other one would be sufficient, but that isn't obvious here (and I don't know if people got a notification for that).

As mentioned on the other thread, D88423 <https://reviews.llvm.org/D88423> fixes *only* the bitcode writer part of bug 2, but not the IR printing half, and better test cases are floating around now too so I'll abandon that patch. @arsenm I'm happy to help review and test the next round of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88241/new/

https://reviews.llvm.org/D88241



More information about the llvm-commits mailing list