[PATCH] D88241: OpaquePtr: Add type to sret attribute

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 17:04:53 PDT 2020


dblaikie added a comment.

In D88241#2299480 <https://reviews.llvm.org/D88241#2299480>, @rsmith wrote:

> In D88241#2299469 <https://reviews.llvm.org/D88241#2299469>, @dblaikie wrote:
>
>> Sorry, should've been some followup here, but there is a fix under review here: https://reviews.llvm.org/D88423
>
> Looks like that's fixing only Bug 2 and not Bug 1, right? (And fixing Bug 1 would invalidate the testcase.) Or is the value enumerator also used by the module linker?

Ah, quite possibly - I'm not rightly sure. Will pick it up over on the other review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88241/new/

https://reviews.llvm.org/D88241



More information about the llvm-commits mailing list