[PATCH] D87543: AMDGPU: Always split si_end_cf blocks

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 07:55:11 PDT 2020


nhaehnle requested changes to this revision.
nhaehnle added a comment.
This revision now requires changes to proceed.

It's unclear to me what this is trying to achieve. If it is to prevent

  bb:
    <-- reload inserted here during live range splitting
    $exec = S_OR_B64 $exec, %other
    ... rest of code ...

... then this change only replaces it by:

  bb:
    <-- reload inserted here during live range splitting
    $exec = S_OR_B64_term $exec, %other
    // fallthrough
  
  bb.new:
    ... rest of code ...

The inserted reload code is as incorrect as it was before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87543/new/

https://reviews.llvm.org/D87543



More information about the llvm-commits mailing list