[PATCH] D88562: [SVE][CodeGen] Replace more TypeSize comparison operators with their scalar equivalents

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 05:31:25 PDT 2020


david-arm created this revision.
david-arm added reviewers: sdesmalen, efriedma, kmclaughlin.
Herald added subscribers: llvm-commits, ecnelises, steven.zhang, psnobl, hiraditya, tschuett.
Herald added a project: LLVM.
david-arm requested review of this revision.

In certain places in llvm/lib/CodeGen we were relying upon the TypeSize
comparison operators when in fact the code was only ever expecting
either scalar values or fixed width vectors. This patch changes a few
functions that were always expecting to work on scalar or fixed width
types:

1. DAGCombiner::mergeTruncStores - deals with scalar integers only.
2. DAGCombiner::ReduceLoadWidth - not valid for vectors.
3. DAGCombiner::createBuildVecShuffle - should only be used for fixed width vectors.
4. SelectionDAGLegalize::ExpandFCOPYSIGN and SelectionDAGLegalize::getSignAsIntValue - only work on scalars.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88562

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88562.295251.patch
Type: text/x-patch
Size: 8951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200930/56bea474/attachment.bin>


More information about the llvm-commits mailing list