[PATCH] D88482: [SVE][CodeGen] Replace TypeSize comparison operators with their scalar equivalents

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Hi @efriedma, sure I can do that. To be honest (and this is probably my lack of understanding of what is meant by a functional change) I thought they were almost all non-functional. That's why I originally put them in this patch together. Just for my understanding, which bits do you consider non-functional? I can definitely see that one change in TargetLowering is non-functional, but in other cases such as mergeTruncStores where I call getScalarSizeInBits() instead of getSizeInBits() to me, naively, this seemed non-functional because we're dealing with scalar values - the function bails out if the type is not a simple integer. Similarly in ReduceLoadWidth we bail out immediately if the type is a vector, so from that point onwards the type is guaranteed to be scalar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88482/new/

https://reviews.llvm.org/D88482