[PATCH] D88340: Patch IEEEFloat::isSignificandAllZeros and IEEEFloat::isSignificandAllOnes (bug 34579)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 21:54:13 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Support/APFloat.cpp:845
   const integerPart *Parts = significandParts();
   const unsigned PartCount = partCount();
+
----------------
Does the original code just work if we change this line to "unsigned PartCount = partCountForBits(semantics->precision)"? That will calculate the part count without the guard bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88340/new/

https://reviews.llvm.org/D88340



More information about the llvm-commits mailing list