[PATCH] D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1648
         report("Expected a register operand.", MO, MONum);
-      if ((MCOI.OperandType == MCOI::OPERAND_IMMEDIATE ||
-           MCOI.OperandType == MCOI::OPERAND_PCREL) && MO->isReg())
+      if (MCOI.OperandType == MCOI::OPERAND_IMMEDIATE && MO->isReg())
         report("Expected a non-register operand.", MO, MONum);
----------------
I wonder whether this should be a TII (or similar) hook/field instead; weakening assertions for targets where the assertion is valid is a bit sad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88386/new/

https://reviews.llvm.org/D88386