[PATCH] D88457: [scudo][standalone] Fix some primary tests

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 11:46:56 PDT 2020


cryptoad added a comment.

In D88457#2301551 <https://reviews.llvm.org/D88457#2301551>, @pcc wrote:

> I'm not really a fan of long lists of template arguments. So I would favor something like
>
> 3. Have the SizeClassAllocator classes take something like a Config type (see allocator_config.h) as a template argument and have it read the configuration out of that.

I like this as well, also because it keep symbols shorter and easier to read.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88457/new/

https://reviews.llvm.org/D88457



More information about the llvm-commits mailing list