[PATCH] D88485: [SDag][AMDGPU] Maintain DAG divergence through instruction selection

Tue Sep 29 10:29:29 PDT 2020

rampitec added a comment.

In D88485#2301282 <https://reviews.llvm.org/D88485#2301282>, @foad wrote:

> In D88485#2301154 <https://reviews.llvm.org/D88485#2301154>, @rampitec wrote:
>
>> However, I do not like that list of opcodes in the isSDNodeSourceOfDivergence(), it is error prone.
>
> These lists are the SDNode equivalents of `GCNTTIImpl::isSourceOfDivergence` (which uses some data defined in .td files) and `GCNTTIImpl::isAlwaysUniform`. I don't know if there's a better way to generate them.

It can use a flag in Desc I think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88485/new/

https://reviews.llvm.org/D88485