[PATCH] D88499: [NFC][regalloc] Make VirtRegAuxInfo part of allocator state

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 10:13:12 PDT 2020


qcolombet requested changes to this revision.
qcolombet added a comment.
This revision now requires changes to proceed.

Hi,

>From the perspective of the caller, this patch exposes some implementation details that I am not sure are worth it.

Put differently, what is the expected benefits of moving VRAI life-time to the allocators?

VRAI are relatively light-weight objects and I wouldn't expect saving on the constructor to bring us any gain. So what are we after here?

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88499/new/

https://reviews.llvm.org/D88499



More information about the llvm-commits mailing list