[PATCH] D88461: [ELF] Fix multiple -mllvm after D70378

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 10:09:02 PDT 2020


aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

Looks good with one minor comment.



================
Comment at: lld/ELF/Driver.cpp:1108
   // Parse LTO options.
+  cl::ResetAllOptionOccurrences();
   if (auto *arg = args.getLastArg(OPT_plugin_opt_mcpu_eq))
----------------
I would put this line just above the comment, because it has to do more with options in general, rather than LTO options specifically, but that's my preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88461/new/

https://reviews.llvm.org/D88461



More information about the llvm-commits mailing list