[PATCH] D88456: [COFF][CG Profile] set undefined symbol to external

[Zequan Wu via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGa9abe1f7859e: [COFF][CG Profile] set undefined symbol to external (authored by zequanwu).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88456/new/

https://reviews.llvm.org/D88456

Files:
  llvm/lib/MC/MCWinCOFFStreamer.cpp
  llvm/test/MC/COFF/cgprofile.s


Index: llvm/test/MC/COFF/cgprofile.s
===================================================================
--- llvm/test/MC/COFF/cgprofile.s
+++ llvm/test/MC/COFF/cgprofile.s
@@ -30,7 +30,7 @@
 # CHECK-NEXT: ]
 # CHECK-NEXT: SectionData (
 # CHECK-NEXT:   0000: 0A000000 0E000000 20000000 00000000
-# CHECK-NEXT:   0010: 11000000 0A000000 0B000000 00000000
+# CHECK-NEXT:   0010: 0F000000 0A000000 0B000000 00000000
 # CHECK-NEXT:   0020: 0B000000 0C000000 14000000 00000000
 # CHECK-NEXT: )
 
@@ -68,37 +68,15 @@
 # CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED
 # CHECK-NEXT: BaseType:
 # CHECK-NEXT: ComplexType:
-# CHECK-NEXT: StorageClass: WeakExternal
-# CHECK-NEXT: AuxSymbolCount: 1
-# CHECK-NEXT: AuxWeakExternal {
-# CHECK-NEXT:   Linked: .weak.b.default.late
-# CHECK-NEXT:   Search: Alias
-# CHECK-NEXT: }
-# CHECK:      Name: .weak.b.default.late
-# CHECK-NEXT: Value:
-# CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE
-# CHECK-NEXT: BaseType:
-# CHECK-NEXT: ComplexType:
 # CHECK-NEXT: StorageClass: External
-# CHECK-NEXT: AuxSymbolCount: 0
+# CHECK-NEXT: AuxSymbolCount:
 # CHECK:      Name: freq
 # CHECK-NEXT: Value:
 # CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED
 # CHECK-NEXT: BaseType:
 # CHECK-NEXT: ComplexType:
-# CHECK-NEXT: StorageClass: WeakExternal
-# CHECK-NEXT: AuxSymbolCount: 1
-# CHECK-NEXT: AuxWeakExternal {
-# CHECK-NEXT:   Linked: .weak.freq.default.late
-# CHECK-NEXT:   Search: Alias
-# CHECK-NEXT: }
-# CHECK:      Name: .weak.freq.default.late
-# CHECK-NEXT: Value:
-# CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE
-# CHECK-NEXT: BaseType:
-# CHECK-NEXT: ComplexType:
 # CHECK-NEXT: StorageClass: External
-# CHECK-NEXT: AuxSymbolCount: 0
+# CHECK-NEXT: AuxSymbolCount:
 
 # CHECK:      CGProfile [
 # CHECK-NEXT:   CGProfileEntry {
Index: llvm/lib/MC/MCWinCOFFStreamer.cpp
===================================================================
--- llvm/lib/MC/MCWinCOFFStreamer.cpp
+++ llvm/lib/MC/MCWinCOFFStreamer.cpp
@@ -340,10 +340,8 @@
   const MCSymbol *S = &SRE->getSymbol();
   bool Created;
   getAssembler().registerSymbol(*S, &Created);
-  if (Created) {
-    cast<MCSymbolCOFF>(S)->setIsWeakExternal();
+  if (Created)
     cast<MCSymbolCOFF>(S)->setExternal(true);
-  }
 }
 
 void MCWinCOFFStreamer::finalizeCGProfile() {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88456.295022.patch
Type: text/x-patch
Size: 2251 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200929/62129ee0/attachment.bin>