[PATCH] D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 02:57:12 PDT 2020


jonpa updated this revision to Diff 294918.
jonpa added a comment.

Updated per review.

Checking a GlobalAddress without an explicit check for a PCREL_ BasePtr is now done instead by assuming that this will always be in the first operand of BasePtr. Not sure if this is better... Perhaps better to either assume that all GlobalAddress nodes are lowered with a PCREL_ node (call isPCRel()), or maybe check *all* operands of BasePtr for a GlobalAddress?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87510/new/

https://reviews.llvm.org/D87510

Files:
  llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp
  llvm/lib/Target/SystemZ/SystemZOperators.td
  llvm/test/CodeGen/SystemZ/int-move-10.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87510.294918.patch
Type: text/x-patch
Size: 9729 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200929/c9aecf8b/attachment.bin>


More information about the llvm-commits mailing list