[PATCH] D88291: [AMDGPU] Insert waterfall loops for divergent calls

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:4897
+  MI.dump();
+  Begin->dump();
+  MachineBasicBlock::iterator I(&MI);
----------------
Dump() is not required.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5127
+    MachineOperand *Dest = &MI.getOperand(0);
+    if (!RI.isSGPRClass(MRI.getRegClass(Dest->getReg()))) {
+      // Also move the copies to physical registers into the loop block
----------------
Should this block be executed for AGPRs too? If this is meant only for VGPRs then !SGPR is not correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88291/new/

https://reviews.llvm.org/D88291