[PATCH] D73739: Exception support for basic block sections

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 22:44:21 PDT 2020


MaskRay added a comment.

Let's take gcc_except_table_bb_sections.ll as the example:

  .uleb128 .Lcst_end0-.Lcst_begin0  # Call Site Size
  
  .uleb128 .Lcst_end0-.Lcst_begin1  # Call Site Size
  
  .uleb128 .Lcst_end0-.Lcst_begin1  # Call Site Size

I think the Call Site Sizes are incorrect. A pair of .Lcst_end0 and .Lcst_begin0 should exactly delimiter the call sites table, but the correct implements uses `.Lcst_end0` for all 3 basic block sections and places  `.Lcst_end0` after the last Call Site Table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739



More information about the llvm-commits mailing list