[PATCH] D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: lld/ELF/Config.h:115
+
+  // The minimum hotness value a diagnostic needs in order to be included in
+  // optimization diagnostics.
----------------
Don't repeat the include/llvm/LTO/Config.h comment here

lld just forwards these options. Their help messages should be in llvm/LTO/


================
Comment at: lld/ELF/Driver.cpp:995
+      error(arg->getSpelling() + ": invalid argument '" + arg->getValue() +
+            "', only integer or 'auto' is supported.");
+    else
----------------
delete trailing period


================
Comment at: llvm/include/llvm/Remarks/HotnessThresholdParser.h:20
+#include "llvm/Support/CommandLine.h"
+namespace llvm {
+namespace remarks {
----------------
empty line before `namespace`


================
Comment at: llvm/include/llvm/Support/CommandLine.h:1484
   explicit opt(const Mods &... Ms)
-      : Option(Optional, NotHidden), Parser(*this) {
+      : Option(llvm::cl::Optional, NotHidden), Parser(*this) {
     apply(this, Ms...);
----------------
Unrelated change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809