[PATCH] D84681: [VPlan] Use VPValue def for VPWidenCall.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:809
 /// A recipe for widening Call instructions.
-class VPWidenCallRecipe : public VPRecipeBase {
-  /// Hold the call to be widened.
-  CallInst &Ingredient;
-
+class VPWidenCallRecipe : public VPRecipeBase, public VPValue {
   /// Hold VPValues for the arguments of the call.
----------------
VPUser too? Or is that simpler to do later?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:816
   VPWidenCallRecipe(CallInst &I, iterator_range<IterT> CallArguments)
-      : VPRecipeBase(VPWidenCallSC), Ingredient(I), User(CallArguments) {}
+      : VPRecipeBase(VPWidenCallSC), VPValue(VPValue::VPVWidenCallSC, &I),
+        User(CallArguments) {}
----------------
VPRecipeBase(VPWidenCallSC) -> VPRecipeBase(VPRecipeBase::VPWidenCallSC). To make it explicit whilst there are two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84681/new/

https://reviews.llvm.org/D84681