[PATCH] D88210: [IndVars] Use knowledge about execution on last iteration when removing checks

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 09:56:25 PDT 2020


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Marking as Needs Changes purely to indicate I'm holding off on reviewing this in depth until changes this is built upon have all landed.  Please refresh at that point.

Max, have you looked at SCEV->isLoopInvariantPredicate?  It tries to handle some of the same reasoning.  It might be useable directly here, or if not, can the logic maybe be consolidated in one place rather than two?  I have not looked at this in depth yet, but that'll be the question I'm asking myself when reviewing this in detail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88210/new/

https://reviews.llvm.org/D88210



More information about the llvm-commits mailing list