[PATCH] D88401: [lib/Support/CommandLine][windows] - Handle "\ " as a space token.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 09:47:55 PDT 2020


rnk added a comment.

I am skeptical of this change. TokenizeWindowsCommandLine is meant to precisely implement the behavior of how the Visual C runtime tokenizes command lines, which generally also matches how MSVC tools parse response files. Any deviation from these rules generally leads to problems, and we've been pretty careful so far.

The linked bug describes attempts to use LLD as a drop-in replacement for binutils gold, which uses GNU parsing rules, so we shouldn't be using TokenizeWindowsCommandLine. Maybe you want to use TokenizeGNUCommandLine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88401/new/

https://reviews.llvm.org/D88401



More information about the llvm-commits mailing list