[PATCH] D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:3440
+/// intrinsic.
+class DIArgList : public MDNode {
+  friend class LLVMContextImpl;
----------------
aprantl wrote:
> Why doesn't this inherit from, e.g., `MDTuple` or have multiple `MDOperand`s?
The short explanation is that this doesn't use the built-in MD operands at all - you'll notice that we pass `None` to the `Ops` argument in the `MDNode` constructor below. The baisc reason for that is that the way the MDOperands are handled has some incompatibilities with the intended use of the DIArgList arguments. I'll have to go back over my work to collect a more specific set of reasons as to why using `MDOperands` doesn't work for this. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88175/new/

https://reviews.llvm.org/D88175