[PATCH] D88232: [DebugInfo] Handle multiple variable location operands in IR

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

This mostly LGTM.



================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1197
+      if (auto *DVI = dyn_cast<DbgVariableIntrinsic>(&Inst))
+        for (Value *V : DVI->getVariableLocationOps())
+          if (auto *Alloca = dyn_cast_or_null<AllocaInst>(V))
----------------
That's how :-)


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1277
+      for (auto &Inst : BB) {
+        if (auto *DVI = dyn_cast<DbgVariableIntrinsic>(&Inst)) {
+          for (Value *V : DVI->getVariableLocationOps()) {
----------------
nit: remove redundant {}?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88232/new/

https://reviews.llvm.org/D88232