[PATCH] D88420: [InstCombine] matchRotate - support non-uniform constant vector rotation amounts (PR46895)

Mon Sep 28 07:56:22 PDT 2020

RKSimon created this revision.
RKSimon added reviewers: lebedev.ri, nikic, spatel, efriedma, majnemer.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
RKSimon requested review of this revision.

Complete PR46895 by refactoring D87452 <https://reviews.llvm.org/D87452>/D88402 <https://reviews.llvm.org/D88402> to allow us to match non-uniform constant values.

To handle the various undef cases this ended up being a lot bulkier than I hoped - I'd love to hear if anyone has any suggestions on how we could use ConstantExpr/PatternMatch to simplify this as I imagine we could use such functionality in other places as we improve non-uniform vector support.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88420

Files:
  llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  llvm/test/Transforms/InstCombine/rotate.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88420.294705.patch
Type: text/x-patch
Size: 6060 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200928/238fbe90/attachment.bin>