[PATCH] D88166: [SCEV] Verify that all mapped SCEV AddRecs refer to valid loops.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 07:53:52 PDT 2020


fhahn added a comment.

> It would probably be even better to iterate over all unique SCEVs, but
> that currently causes a few assertion in loop fusion, which I still need
> to investigate.

I took a look at the assertion failures in loop fusion when iterating over all `UniqueSCEVs`. Loop fusion uses a SCEV rewriter to map SCEVs from one loop to another to check distances between expressions, but they are not used subsequently. This results in some expressions in `UniqueSCEVs` that reference the old loop, but are not referenced by any expression. I think that shouldn't be a big problem, especially as we currently do not have a convenient way to remove entries from `UniqueSCEVs`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88166/new/

https://reviews.llvm.org/D88166



More information about the llvm-commits mailing list