[PATCH] D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:407
 
+static bool isConstantOne(const Value* V) {
+  const ConstantInt *CI = dyn_cast<ConstantInt>(V);
----------------
foad wrote:
> It would be neater to have a BuildMul helper function that checks for and optimizes the mul-by-1 case.
A new BuildMul or update the current one (looks like some unittests need to be updated in this case)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88315/new/

https://reviews.llvm.org/D88315