[PATCH] D88407: [llvm-readobj/elf] - Fix the PREL31 relocation computation used for dumping arm32 unwind info (-u).

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 06:21:01 PDT 2020


grimar added a comment.

In D88407#2297935 <https://reviews.llvm.org/D88407#2297935>, @psmith wrote:

> LGTM. Agree that it should be bit31 that is sign extended. Apologies for not catching this last time.

No worries. This and few other issues are/were mentioned in comments on the bug page. They are about 6 years old,
I guess nobody tried to heavily use "llvm-readobj -u" before. I am going to try to fix all of them. Thanks for quick review!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88407/new/

https://reviews.llvm.org/D88407



More information about the llvm-commits mailing list