[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

[Atmn Patel via Phabricator via llvm-commits]

atmnpatel added inline comments.


================
Comment at: llvm/test/Analysis/ScalarEvolution/2012-03-26-LoadConstant.ll:1
-; RUN: opt < %s -basic-aa -globalopt -instcombine -loop-rotate -licm -instcombine -indvars -loop-deletion -constmerge -S | FileCheck %s
+; RUN: opt < %s -basic-aa -globalopt -instcombine -loop-rotate -licm -instcombine -indvars -loop-deletion -constmerge -simplifycfg -S | FileCheck %s
 ; PR11882: ComputeLoadConstantCompareExitLimit crash.
----------------
jdoerfert wrote:
> Why?
If we don't apply the pass, there are extra labels that are generated and left there i.e.
``   br label %step1
   step1:
     br label %step2
   step2:
   ...
``
Does it make sense to remove that extra pass and check for this?


================
Comment at: llvm/test/Transforms/LoopDeletion/mustprogress.ll:46
+; CHECK:    br label %[[FOR_COND1]]
+; CHECK: }
+
----------------
jdoerfert wrote:
> The result is the same as above because the function attribute is still present. Is that intended?
Yep, just wanted to cover all bases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86844/new/

https://reviews.llvm.org/D86844