[PATCH] D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation

Dominic Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 26 15:55:17 PDT 2020


ddcc created this revision.
ddcc added reviewers: eugenis, aprantl, ostannard.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
ddcc requested review of this revision.
Herald added a subscriber: ormris.

When ASan and e.g. Dead Virtual Function Elimination are enabled, the
latter will rely on type metadata to determine if certain virtual calls can be
removed. However, ASan currently does not copy type metadata, which can cause
virtual function calls to be incorrectly removed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88368

Files:
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
  llvm/test/Instrumentation/AddressSanitizer/debug_info.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88368.294522.patch
Type: text/x-patch
Size: 6119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200926/760cb075/attachment.bin>


More information about the llvm-commits mailing list