[PATCH] D87732: [Support] Provide sys::path::guess_style

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D87732#2296149 <https://reviews.llvm.org/D87732#2296149>, @amccarth wrote:

> In D87732#2296076 <https://reviews.llvm.org/D87732#2296076>, @rnk wrote:
>
>> Separately, I would like LLVM to move in the direction of standardizing on forward slashes in internal representations and data structures.
>
> If we move that direction, we'll have to re-think VFS again.  I'll also lobby hard to make sure that we show the native representation in compiler output, like diagnostic messages.

There's also a case where the opposite is wanted; when operating in mingw mode, there's a predecent of GCC outputting paths with forward slashes. This is needed for cases where e.g. libtool parses the output of e.g. `$CC -v` for the linker command/options, and the output of `$CC --print-search-dirs`. (libtool is largely implemented in shellscript, tolerating backslashes would require lots of changes to how things are quoted/escaped, and libtool is essentially unmaintained at this point...) See https://reviews.llvm.org/D53066 for an earlier attempt at fixing that, which I had to revert, because I attempted it at the wrong level and it turned out to be much more of a mess than I expected...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87732/new/

https://reviews.llvm.org/D87732